Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Coverage and Quality Report: add information about use of forced-colors media query in examples #2902

Closed
wants to merge 2 commits into from
Closed

Coverage and Quality Report: add information about use of forced-colors media query in examples #2902

wants to merge 2 commits into from

Conversation

jongund
Copy link
Contributor

@jongund jongund commented Jan 16, 2024 •
edited by daniel-montalvo
Loading

Part of resolution of issue #2864.

Preview Link

Preview revised coverage and quality report in compare branch

WAI Preview Link (Last built on Mon, 06 May 2024 06:10:39 GMT).

@jongund jongund requested a review from mcking65 January 16, 2024 19:41
@ariellalgilmore ariellalgilmore mentioned this pull request Jan 16, 2024
Merged
6 tasks
@daniel-montalvo daniel-montalvo mentioned this pull request Jan 16, 2024
Closed
@mcking65 mcking65 changed the title add information on using forced-colors media query in CSS in examples Coverage and Quality Report: add information about use of forced-colors media query in examples Apr 15, 2024
@mcking65 mcking65 mentioned this pull request Apr 15, 2024
Open
@a11ydoer a11ydoer requested a review from howard-e April 23, 2024 18:17
@css-meeting-bot
Copy link
Member

The ARIA Authoring Practices (APG) Task Force just discussed Coverage and Quality Report: add information about use of forced-colors media query in examples.

The full IRC log of that discussion <jugglinmike> Subtopic: Coverage and Quality Report: add information about use of forced-colors media query in examples
<jugglinmike> github: https://github.com//pull/2902
<jugglinmike> Matt_King: We don't have any reviewers assigned here. Is this ready for review?
<jugglinmike> Matt_King: There are some conflicting files in this pull request because we changed how the report date is being generated (now, it's being generated during build instead of when the report is run)
<jugglinmike> Matt_King: Actually, it is only a conflict in the generated file... I wonder, is this a matter of jongund merging the "main" branch into his branch...?
<jugglinmike> Matt_King: I would like howard-e to look at this because he recently looked at the quality report stuff and I want to make sure it's all in-line with those other changes
<jugglinmike> Jem: I've assigned howard-e and added his name to the checklist in the pull request description

@howard-e
Copy link
Contributor

howard-e commented Apr 24, 2024 •
edited
Loading

Re: #2902 (comment)

I would like howard-e to look at this because he recently looked at the quality report stuff and I want to make sure it's all in-line with those other changes

Seems fine to me. This branch is just a bit outdated now and conflicts with changes to content/about/coverage-and-quality/coverage-and-quality-report.html introduced by this change rather than by the last updated modification changes.

Merging in main, fully accepting either main or this PR's changes for content/about/coverage-and-quality/coverage-and-quality-report.html (to make things easier for the conflict resolution I suppose) and then running npm run coverage-report before pushing again will be fine.

@mcking65
Copy link
Contributor

mcking65 commented May 6, 2024

@jongund ... I merged main and resolved conflicts but linters are failing now. Pls have a look.

@mcking65 mcking65 mentioned this pull request May 21, 2024
Merged
@mcking65
Copy link
Contributor

replaced by #3024 so closing.

@mcking65 mcking65 closed this Jul 28, 2024
@mcking65 mcking65 deleted the dev/media-query-forced-colors branch July 28, 2024 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcking65 mcking65 Awaiting requested review from mcking65

@howard-e howard-e Awaiting requested review from howard-e

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jongund @css-meeting-bot @howard-e @mcking65